Only change builtin types in UseTypesFromTypingRule
#178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Problem*
`UseTypesFromTypingRule` incorrectly changed `list` to `List` in
this real-world snippet:
```
from typing import List as list
from graphene import List
def function(a: list[int]) -> List[int]:
return []
```
*Solution*
Refine the check to confirm the node is a builtin
facebook-github-bot
added
the
CLA Signed
|
LGTM, @alambert, thanks for contributing! |
jimmylai
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
UseTypesFromTypingRuleincorrectly changed list to List in this real-world snippet:Solution
Refine the check to confirm the node is a builtin
Test Plan
Added test and ran
tox -e py38 -- fixit.tests.UseTypesFromTypingRule