Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for formatting code after applying fixes #335

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

amyreese
Copy link
Member

@amyreese amyreese commented Jun 28, 2023

Stack from ghstack (oldest at bottom):

  • New formatter config option
  • New Formatter class and format_module to define formatting
    interface and method of tracking available formatters.
  • Builtin support for black and ufmt styles
  • Prototype support for alternative formatters by extending the
    Formatter class at runtime
  • Updated configuration guide, and added formatter section to API docs

Fixes #307

- New `formatter` config option
- New `Formatter` class and `format_module` to define formatting
  interface and method of tracking available formatters.
- Builtin support for `black` and `ufmt` styles
- Prototype support for alternative formatters by extending the
  `Formatter` class at runtime
- Updated configuration guide, and added formatter section to API docs

Fixes #307

[ghstack-poisoned]
@amyreese amyreese requested a review from zsol as a code owner June 28, 2023 00:42
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 28, 2023
amyreese added a commit that referenced this pull request Jun 28, 2023
- New `formatter` config option
- New `Formatter` class and `format_module` to define formatting
  interface and method of tracking available formatters.
- Builtin support for `black` and `ufmt` styles
- Prototype support for alternative formatters by extending the
  `Formatter` class at runtime
- Updated configuration guide, and added formatter section to API docs

Fixes #307

ghstack-source-id: 822604f955207d80de9ce47792b574286252cfea
Pull Request resolved: #335
@amyreese amyreese added this to the 2.0 milestone Jun 28, 2023
- New `formatter` config option
- New `Formatter` class and `format_module` to define formatting
  interface and method of tracking available formatters.
- Builtin support for `black` and `ufmt` styles
- Prototype support for alternative formatters by extending the
  `Formatter` class at runtime
- Updated configuration guide, and added formatter section to API docs

Fixes #307

[ghstack-poisoned]
@amyreese amyreese changed the title Add support for formatting code after appling fixes Add support for formatting code after applying fixes Jun 28, 2023
amyreese added a commit that referenced this pull request Jun 28, 2023
- New `formatter` config option
- New `Formatter` class and `format_module` to define formatting
  interface and method of tracking available formatters.
- Builtin support for `black` and `ufmt` styles
- Prototype support for alternative formatters by extending the
  `Formatter` class at runtime
- Updated configuration guide, and added formatter section to API docs

Fixes #307

ghstack-source-id: 822604f955207d80de9ce47792b574286252cfea
Pull Request resolved: #335
@amyreese amyreese merged commit 575fae8 into gh/amyreese/3/base Jun 28, 2023
amyreese added a commit that referenced this pull request Jun 28, 2023
- New `formatter` config option
- New `Formatter` class and `format_module` to define formatting
  interface and method of tracking available formatters.
- Builtin support for `black` and `ufmt` styles
- Prototype support for alternative formatters by extending the
  `Formatter` class at runtime
- Updated configuration guide, and added formatter section to API docs

Fixes #307

ghstack-source-id: 822604f955207d80de9ce47792b574286252cfea
Pull Request resolved: #335
@amyreese amyreese deleted the gh/amyreese/3/head branch June 28, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants