Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option for absolute rule imports from project root #338

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Option for absolute rule imports from project root #338

merged 3 commits into from
Jul 7, 2023

Conversation

amyreese
Copy link
Member

@amyreese amyreese commented Jul 6, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

  • New enable-root-import config option for root configs
  • Add root config directory, or specified relative path, to sys.path
    before materializing configured lint rules.
  • Tests
  • Documentation

Fixes #316

@amyreese
Option for absolute rule imports from project root
9152af6 
- New `enable-root-import` config option for root configs
- Add root config directory, or specified relative path, to `sys.path`
  before materializing configured lint rules.
- Tests
- Documentation

Fixes #316

[ghstack-poisoned]
@amyreese amyreese requested a review from zsol as a code owner July 6, 2023 04:59
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 6, 2023
amyreese added a commit that referenced this pull request Jul 6, 2023
@amyreese
Option for absolute rule imports from project root
0b9d1be 
- New `enable-root-import` config option for root configs
- Add root config directory, or specified relative path, to `sys.path`
  before materializing configured lint rules.
- Tests
- Documentation

Fixes #316

ghstack-source-id: 0135361c8f7c5b61998de1fa07fe3a4fb11bfed5
Pull Request resolved: #338
@amyreese
Update on "Option for absolute rule imports from project root"
2a8f6b7 
- New `enable-root-import` config option for root configs
- Add root config directory, or specified relative path, to `sys.path`
  before materializing configured lint rules.
- Tests
- Documentation

Fixes #316

[ghstack-poisoned]
amyreese added a commit that referenced this pull request Jul 6, 2023
@amyreese
Option for absolute rule imports from project root
039eb76 
- New `enable-root-import` config option for root configs
- Add root config directory, or specified relative path, to `sys.path`
  before materializing configured lint rules.
- Tests
- Documentation

Fixes #316

ghstack-source-id: ca9ce72cebf5100b7aa9aff3ee5cdcdf50e2130c
Pull Request resolved: #338
@amyreese
Update on "Option for absolute rule imports from project root"
3a7bd24 
- New `enable-root-import` config option for root configs
- Add root config directory, or specified relative path, to `sys.path`
  before materializing configured lint rules.
- Tests
- Documentation

Fixes #316

[ghstack-poisoned]
@amyreese amyreese mentioned this pull request Jul 6, 2023
Merged
amyreese added a commit that referenced this pull request Jul 6, 2023
@amyreese
Option for absolute rule imports from project root
29409ef 
- New `enable-root-import` config option for root configs
- Add root config directory, or specified relative path, to `sys.path`
  before materializing configured lint rules.
- Tests
- Documentation

Fixes #316

ghstack-source-id: 75d01c6246824d6ad494969f9fc7267cc90095a0
Pull Request resolved: #338
@amyreese amyreese mentioned this pull request Jul 6, 2023
Merged
@amyreese amyreese merged commit 3a7bd24 into gh/amyreese/3/base Jul 7, 2023
13 checks passed
amyreese added a commit that referenced this pull request Jul 7, 2023
@amyreese
Option for absolute rule imports from project root
be947ac 
- New `enable-root-import` config option for root configs
- Add root config directory, or specified relative path, to `sys.path`
  before materializing configured lint rules.
- Tests
- Documentation

Fixes #316

ghstack-source-id: 75d01c6246824d6ad494969f9fc7267cc90095a0
Pull Request resolved: #338
@amyreese amyreese deleted the gh/amyreese/3/head branch July 7, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsol zsol Awaiting requested review from zsol

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amyreese @facebook-github-bot