Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpers to find and add suppressions comments to nodes #451

Open
wants to merge 3 commits into
base: gh/amyreese/2/base
Choose a base branch
from
Open

Add helpers to find and add suppressions comments to nodes #451

wants to merge 3 commits into from

Conversation

amyreese
Copy link
Member

@amyreese amyreese commented May 1, 2024 •
edited
Loading

@amyreese
Update
fffd006 
[ghstack-poisoned]
@amyreese amyreese requested a review from zsol as a code owner May 1, 2024 01:57
@amyreese amyreese mentioned this pull request May 1, 2024
Open
amyreese added a commit that referenced this pull request May 1, 2024
@amyreese
Add helpers to find and add suppressions comments to nodes
8a187b2 
ghstack-source-id: 92333ed112203d05ca54ca1dd29126ef7fbe63de
Pull Request resolved: #451
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2024
zsol
zsol approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add typing extensions to Fixit's dependencies now (it was only pulled in by libcst for up to 3.8)

src/fixit/ftypes.py Show resolved Hide resolved
@amyreese
Update
2606f33 
[ghstack-poisoned]
amyreese added a commit that referenced this pull request Jul 16, 2024
@amyreese
Add helpers to find and add suppressions comments to nodes
dbcb55a 
ghstack-source-id: 9b82e32a9ead5ae5141304f5d00ccc26bdfe8065
Pull Request resolved: #451
@amyreese
Update
7b98430 
[ghstack-poisoned]
amyreese added a commit that referenced this pull request Jul 17, 2024
@amyreese
Add helpers to find and add suppressions comments to nodes
1641a1e 
ghstack-source-id: 335bd9c9429131803285dbac2cc782bf9f78c4ef
Pull Request resolved: #451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsol zsol zsol approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amyreese @zsol @facebook-github-bot