[typing] enable Pyre strict mode by default

.circleci/.pyre_configuration

@@ -7,5 +7,6 @@
     ],
     "exclude": [
         ".*/\\.tox/.*"
-    ]
+    ],
+    "strict": true
 }

.pyre_configuration.example

@@ -8,4 +8,5 @@
     "exclude": [
         ".*/\\.tox/.*"
     ]
+    "strict": true
 }

docs/source/conf.py

@@ -2,6 +2,7 @@
 #
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
+# pyre-unsafe
 
 # -*- coding: utf-8 -*-
 #

libcst/__init__.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from libcst._batched_visitor import BatchableCSTVisitor, visit_batched
 from libcst._exceptions import MetadataException, ParserSyntaxError
 from libcst._maybe_sentinel import MaybeSentinel

libcst/_add_slots.py

@@ -2,7 +2,6 @@
 # https://github.com/ericvsmith/dataclasses/blob/ae712dd993420d43444f188f452/LICENSE.txt
 # https://github.com/ericvsmith/dataclasses/blob/ae712dd993420d43444f/dataclass_tools.py
 
-# pyre-strict
 import dataclasses
 from typing import Any, Mapping, Type, TypeVar
 

libcst/_batched_visitor.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 import inspect
 from typing import (
     TYPE_CHECKING,

libcst/_exceptions.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from enum import Enum, auto
 from typing import Any, Callable, Iterable, Optional, Sequence, Tuple, Union
 

libcst/_maybe_sentinel.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from enum import Enum, auto
 
 

libcst/_metadata_dependent.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 #
-# pyre-strict
 import inspect
 from abc import ABC
 from contextlib import contextmanager

libcst/_nodes/__init__.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 
 """
 This package contains CSTNode and all of the subclasses needed to express Python's full

libcst/_nodes/base.py

@@ -449,6 +449,7 @@ def __repr__(self) -> str:
         return "\n".join(lines)
 
     @classmethod
+    # pyre-fixme[3]: Return annotation cannot be `Any`.
     def field(cls, *args: object, **kwargs: object) -> Any:
         """
         A helper that allows us to easily use CSTNodes in dataclass constructor

libcst/_nodes/deep_equals.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 """
 Provides the implementation of `CSTNode.deep_equals`.
 """

libcst/_nodes/expression.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 
 import re
 from abc import ABC, abstractmethod
@@ -427,6 +426,7 @@ def _visit_and_replace_children(self, visitor: CSTVisitorT) -> "Integer":
 
     def _validate(self) -> None:
         super(Integer, self)._validate()
+        # pyre-fixme[16]: Module `tokenize` has no attribute `Intnumber`.
         if not re.fullmatch(INTNUMBER_RE, self.value):
             raise CSTValidationError("Number is not a valid integer.")
 
@@ -465,6 +465,7 @@ def _visit_and_replace_children(self, visitor: CSTVisitorT) -> "Float":
 
     def _validate(self) -> None:
         super(Float, self)._validate()
+        # pyre-fixme[16]: Module `tokenize` has no attribute `Floatnumber`.
         if not re.fullmatch(FLOATNUMBER_RE, self.value):
             raise CSTValidationError("Number is not a valid float.")
 
@@ -502,6 +503,7 @@ def _visit_and_replace_children(self, visitor: CSTVisitorT) -> "Imaginary":
 
     def _validate(self) -> None:
         super(Imaginary, self)._validate()
+        # pyre-fixme[16]: Module `tokenize` has no attribute `Imagnumber`.
         if not re.fullmatch(IMAGNUMBER_RE, self.value):
             raise CSTValidationError("Number is not a valid imaginary.")
 

libcst/_nodes/internal.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 
 from contextlib import contextmanager
 from dataclasses import dataclass, field

libcst/_nodes/module.py

@@ -80,6 +80,7 @@ def _visit_and_replace_children(self, visitor: CSTVisitorT) -> "Module":
             has_trailing_newline=self.has_trailing_newline,
         )
 
+    # pyre-fixme[14]: `visit` overrides method defined in `CSTNode` inconsistently.
     def visit(self: _ModuleSelfT, visitor: CSTVisitorT) -> _ModuleSelfT:
         """
         Returns the result of running a visitor over this module.

libcst/_nodes/op.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from abc import ABC, abstractmethod
 from dataclasses import dataclass
 from typing import Tuple

libcst/_nodes/tests/base.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 import dataclasses
 from contextlib import ExitStack
 from dataclasses import dataclass

libcst/_nodes/tests/test_assert.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 
 from typing import Any
 

libcst/_nodes/tests/test_assign.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_atom.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 
 from typing import Any
 

libcst/_nodes/tests/test_attribute.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_await.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_binary_op.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_boolean_op.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_call.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_classdef.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any, Callable
 
 import libcst as cst

libcst/_nodes/tests/test_comment.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Callable
 
 import libcst as cst

libcst/_nodes/tests/test_comparison.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Callable, Optional
 
 import libcst as cst

libcst/_nodes/tests/test_cst_node.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from textwrap import dedent
 from typing import Union
 

libcst/_nodes/tests/test_del.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_dict.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_dict_comp.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_docstring.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 
 from textwrap import dedent
 from typing import Optional

libcst/_nodes/tests/test_else.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_empty_line.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 import libcst as cst
 from libcst._nodes.tests.base import CSTNodeTest, DummyIndentedBlock
 from libcst.testing.utils import data_provider

libcst/_nodes/tests/test_for.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_funcdef.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any, Callable
 
 import libcst as cst

libcst/_nodes/tests/test_global.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_if.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_ifexp.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Callable, Optional
 
 import libcst as cst

libcst/_nodes/tests/test_import.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_indented_block.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Callable, Optional
 
 import libcst as cst

libcst/_nodes/tests/test_lambda.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Callable, Optional
 
 import libcst as cst

libcst/_nodes/tests/test_leaf_small_statements.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 import libcst as cst
 from libcst._nodes.tests.base import CSTNodeTest
 from libcst.testing.utils import data_provider

libcst/_nodes/tests/test_list.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any, Callable
 
 import libcst as cst

libcst/_nodes/tests/test_matrix_multiply.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Any
 
 import libcst as cst

libcst/_nodes/tests/test_module.py

@@ -3,7 +3,6 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# pyre-strict
 from typing import Tuple, cast
 
 import libcst as cst