Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen test failure on 3.9 #304

Closed
thatch opened this issue May 31, 2020 · 0 comments
Closed

Codegen test failure on 3.9 #304

thatch opened this issue May 31, 2020 · 0 comments

Comments

@thatch
Copy link
Contributor

thatch commented May 31, 2020

Once #297 is fixed, there are a couple of failures. This one is that the codegen test fails, and indeed it would create a rather significant diff if you run codegen under 3.9.

https://gist.github.com/thatch/7f402910a46fdbe6c4e17a9493ef91a5

======================================================================
FAIL: test_codegen_clean_matcher_classes (libcst.codegen.tests.test_codegen_clean.TestCodegenClean)
Verifies that codegen of matcher classes would not result in a
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tim/code/LibCST/libcst/codegen/tests/test_codegen_clean.py", line 82, in test_codegen_clean_matcher_classes
    self.assertTrue(
AssertionError: False is not true : libcst.matchers.__init__ needs new codegen!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants