Improve default-version selection logic #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For simplicity, use the new version in all cases.
facebook-github-bot
added
the
CLA Signed
|
Closes #297 |
While were at it, improve the code to work with a likely 3.10 by allowing multiple digits for minor version.
|
@jimmylai can you take a look? |
|
Thanks for adding those clarification comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need this to be able to import at all on 3.9, because there aren't any syntax changes that would warrant it being a separate entry in the list.
Test Plan
Compiled 3.9b1 and this diff enables it in tox.ini.
Failures are filed as separate issues, #304 and #305