Scope provider changes for type annotations #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
zsol
commented
Sep 16, 2023
Comment on lines
2189
to
2202
| self.skipTest( | ||
| "f's body is subject to the annotation scoping rules" | ||
| " created by its type parameters, but it shouldn't be" | ||
| ) | ||
| self.assertEqual(len(inner_assignment.references), 1) |
There was a problem hiding this comment.
Gotta fix this somehow. The things defined in the AnnotationScope should still be accessible from the body, but not the immediately enclosing class assignments
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
==========================================
+ Coverage 91.04% 91.06% +0.02%
==========================================
Files 255 255
Lines 26366 26512 +146
==========================================
+ Hits 24004 24143 +139
- Misses 2362 2369 +7
☔ View full report in Codecov by Sentry. |
zsol
force-pushed
the
pr1014
branch
2 times, most recently
from
21fc1cc
to
0c34d0f
Compare
zsol
force-pushed
the
pr1014
branch
2 times, most recently
from
5a898ea
to
0af5bb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope provider changes for type annotations