Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_fix_pyre_directives.py #1082

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Conversation

anonymousdouble
Copy link
Contributor

@anonymousdouble anonymousdouble commented Jan 1, 2024

Summary

refactor with chain constant value assignment to make code more Pythonic.

Test Plan

refactor with fstring to format string to make code more Pythonic.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 1, 2024
@aleivag
Copy link
Contributor

aleivag commented Jan 3, 2024

@anonymousdouble

This changes are not neutral, and have broken tests

refactor with fstring to format string to make code more Pythonic.
refactor with fstring to format string to make code more Pythonic.
@anonymousdouble
Copy link
Contributor Author

anonymousdouble commented Jan 3, 2024

Thank you.
I just fixed the broken tests by only using a chaining assignment to assign the same value for the first three test methods.

refactor with fstring to format string to make code more Pythonic.
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b31d3d) 91.09% compared to head (2e0d074) 91.09%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
- Coverage   91.09%   91.09%   -0.01%     
==========================================
  Files         255      255              
  Lines       26564    26561       -3     
==========================================
- Hits        24198    24195       -3     
  Misses       2366     2366              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

refactor with chain constant value assignment to make code more Pythonic
@aleivag
Copy link
Contributor

aleivag commented Jan 3, 2024

@anonymousdouble thanks for pushing this, the test pass now yeyy... but the file is not formatted correctly... can you run something like hatch run ufmt format libcst ?

refactor with chain constant value assignment to make code more Pythonic
@aleivag aleivag merged commit dbbfe1e into Instagram:main Jan 3, 2024
21 checks passed
@anonymousdouble
Copy link
Contributor Author

Okay, thank you.
yes, by running hatch run ufmt format libcst, the format check passes successfully.

@aleivag
Copy link
Contributor

aleivag commented Jan 3, 2024

Thank you for pushing thorough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants