-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PEP-696 #1141
Implement PEP-696 #1141
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
+ Coverage 91.12% 91.15% +0.02%
==========================================
Files 256 258 +2
Lines 26567 26740 +173
==========================================
+ Hits 24210 24374 +164
- Misses 2357 2366 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm at a high level, I have some minor comments, the most important thing is to fix the ordering of inflate statements.
Also pls add more test cases for roundtrip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks :)
Summary
This PR adds the ability for LibCST to parse the "=" operator inside of the square brackets as outlined in PEP-696
Major Changes
Additional python tests were added
Additional roundtrip tests were added (taken from the cython implementation)
##Related Links
PEP-696: https://peps.python.org/pep-0696/#grammar-changes
Issue: #1127
Test Plan
Round trip tests we're added