[Pyre] Handle type subscripts when applying annotations. #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jimmylai
approved these changes
Jul 12, 2020
There was a problem hiding this comment.
Can you also apply the same change to _create_import_from_annotation by using one matches() instead of isinstance + ==?
https://github.com/Instagram/LibCST/blob/master/libcst/codemod/visitors/_apply_type_annotations.py#L166
Otherwise, LGTM.
Comment on lines
137
to
140
| if ( | ||
| m.matches(node.value, m.Name()) | ||
| and cst.ensure_type(node.value, cst.Name).value == "Type" | ||
| ): |
There was a problem hiding this comment.
Use matcher to match the value to be simpler and easier to read.
Suggested change
| if ( | |
| m.matches(node.value, m.Name()) | |
| and cst.ensure_type(node.value, cst.Name).value == "Type" | |
| ): | |
| if m.matches(node.value, m.Name(value="type")): |
There was a problem hiding this comment.
I did not know you could use this syntax. 😍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just as we special case "Type" when applying annotations here: https://github.com/Instagram/LibCST/blob/master/libcst/codemod/visitors/_apply_type_annotations.py#L166
We need to do the same in Subscripts
Test Plan
python -m unittest -v libcst.codemod.visitors.tests.test_apply_type_annotations