fix: correctly extract wildcard matchers #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
sk-
added a commit
to sk-/LibCST
that referenced
this pull request
Aug 2, 2020
Note that SaveMatchedNode was already matching leading empty wildcards, however it's value is incorect due to Instagram#337. This is why the test for the leading wildcards are failing, and will be so until Instagram#355 is merged. This fixes Instagram#336.
jimmylai
approved these changes
Aug 14, 2020
Comment on lines
+936
to
+942
| class _SequenceMatchesResult: | ||
| sequence_capture: Optional[ | ||
| Dict[str, Union[libcst.CSTNode, Sequence[libcst.CSTNode]]] | ||
| ] | ||
| matched_nodes: Optional[ | ||
| Union[libcst.CSTNode, MaybeSentinel, Sequence[libcst.CSTNode]] | ||
| ] |
There was a problem hiding this comment.
Great ideal to use dataclass to store them separately!
jimmylai
pushed a commit
that referenced
this pull request
Aug 14, 2020
* fix: SaveMachedNode now matches with trailing empty wildcards Note that SaveMatchedNode was already matching leading empty wildcards, however it's value is incorect due to #337. This is why the test for the leading wildcards are failing, and will be so until #355 is merged. This fixes #336. * fix: _matches_zero_nodes type declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SaveMatchedNodeswithin sequences was not working as expected, the fixes in this PR are:Test Plan
Unit tests