Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include missing test data in install #365

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Conversation

thatch
Copy link
Contributor

@thatch thatch commented Aug 11, 2020

Summary

#331 reports that tests fail in a certain environment; these messages could be more obvious but are because of missing files.

Test Plan

The relevant files were not included in the manifest generated by setup.py egg_info before, and now are.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 11, 2020
Copy link
Contributor

@jimmylai jimmylai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jimmylai jimmylai merged commit 771d5e1 into Instagram:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants