Support relative imports in ATAV qualifier handling #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on diff review of Instagram#536, I investigated relatvie import handling and realized that with minor changes we can now handle them correctly. Relative imports aren't likely in code coming from an automated tool, but they could happen in hand-written stubs if anyone tries to use this codemod tool to merge stubs with code. Added a new test: ``` > python -m unittest libcst.codemod.visitors.tests.test_apply_type_annotations ............................................. ---------------------------------------------------------------------- Ran 45 tests in 2.195s OK ```
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 94.76% 94.75% -0.01%
==========================================
Files 235 235
Lines 23191 23202 +11
==========================================
+ Hits 21976 21986 +10
- Misses 1215 1216 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on diff review of #536,
I investigated relative import handling and realized that with minor
changes we can now handle them correctly.
Relative imports aren't likely in code coming from an automated
tool, but they could happen in hand-written stubs if anyone tries
to use this codemod tool to merge stubs with code.
Test Plan
Added a new test: