Fix typing errors on ATAV #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #542 +/- ##
==========================================
- Coverage 94.76% 94.75% -0.01%
==========================================
Files 235 235
Lines 23199 23205 +6
==========================================
+ Hits 21984 21989 +5
- Misses 1215 1216 +1
Continue to review full report at Codecov.
|
facebook-github-bot
pushed a commit
to facebook/pyre-check
that referenced
this pull request
Nov 2, 2021
Summary: The new version has: - some fixes to reduce edge cases that sometimes prevented us from picking up required imports (this should lead to a couple percent drop in reject rates) - the ability to add `from __future__ import annotations` via a flag on the codemod instead of by picking it up from the stub file - the ability to count how many annotations were actually added, which we could hook into to get quick feedback about how we are doing - the ability to suppress all import statements if no annotations were added, which should greatly reduce the number of junk "dangling import" diffs that we reject. I also discovered that LibCST doesn't actually have pyre support, and as a result the `main` branch of LibCST had typecheck errors due to type refinement mismatches and edge cases that never happen but the type system picks up. I had to put up a new PR with fixes to avoid getting pyre errors here: Instagram/LibCST#542 Reviewed By: grievejia Differential Revision: D32053591 fbshipit-source-id: 913631b3a8e76490e187f1a5d22ffae36bc4e610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have type hints on LibCST but pyre doesn't seem to be fully hooked up.
As a result, the code was fully annotated, and was type-error-free at
runtime, but had multiple places where pyre complained either due to
type refinement not working or type errors coming from branches of
the code that weren't reachable but couldn't be statically ruled out.
Test Plan
I ran unit tests, and vendored the changes into the pyre project to see that they
typecheck.