Correct and simplify logic of recording assignments #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
lpetre
approved these changes
Nov 19, 2021
lpetre
reviewed
Nov 19, 2021
| @@ -446,14 +456,6 @@ def _contains_in_self_or_parent(self, name: str) -> bool: | |||
| """Overridden by ClassScope to hide it's assignments from child scopes.""" | |||
| return name in self | |||
|
|
|||
| def _add_assignment(self, assignment: "BaseAssignment") -> None: | |||
| assignment.scope = self | |||
There was a problem hiding this comment.
@zsol FYI the bug was here, we were changing assignment.scope but not assignment._index
lpetre
deleted the
resolve-scope-self-correctly-when-resolving-assignment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Correctly records scope assignments and simplifies some logic of resolving target scope.
Test Plan
python -m unittest libcst.metadata.tests.test_scope_provider