Support FunctionDef transformations #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tested all of the edge cases I know of: type comments in various locations, non-type-comments, arity mismatches where we should skip, etc. Assuming that all type comments parse, this should work as far as I know. I'll make a separate PR to deal with SyntaxErrors when parsing types, because that is cross-cutting and not specific to FunctionDef.
facebook-github-bot
added
the
CLA Signed
zsol
approved these changes
Jan 17, 2022
This was referenced Jan 28, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested all of the edge cases I know of: type comments in various
locations, non-type-comments, arity mismatches where we should skip,
etc.
Assuming that all type comments parse, all the cases I know of are
now handled correctly.
I'll make a separate PR later this week to deal with SyntaxErrors
when parsing types, because that is cross-cutting and not specific to
FunctionDef; it's probably going to be most easily solved with
some kind of decorator.