Allow trailing whitespace without newline at EOF #611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The native tokenizer was a bit too strict about indentation checking at EOF. This is valid Python:
if 1:\n pass\n
(note the extra space at the end without a newline), but the tokenizer was trying to match the single space at the end as if it was a dedent from level 4 -> 1, which failed (there was never a level 1 indentation).This PR relaxes the tokenizer a bit to allow for such cases. Indentation checking is skipped if after consuming all whitespace at the beginning of the line, we encounter EOF.
Fixes #608
Test Plan
Added unit test.