Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require whitespace right after match #628

Merged

Conversation

isidentical
Copy link
Contributor

Summary

Fixes #627. This check seems like preventing something that is allowed in the regular Python.

Test Plan

Added a test which didn't work before this patch.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #628 (50476f7) into main (2345848) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage   94.78%   94.79%           
=======================================
  Files         245      245           
  Lines       25256    25254    -2     
=======================================
- Hits        23940    23939    -1     
+ Misses       1316     1315    -1     
Impacted Files Coverage Δ
libcst/_nodes/statement.py 95.21% <ø> (+0.06%) ⬆️
libcst/_nodes/tests/test_match.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2345848...50476f7. Read the comment docs.

Copy link
Contributor

@stroxler stroxler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for catching the bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CST node validation error for match without whitespace
4 participants