-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to regenerate test fixtures, upgrade to Pyre 0.9.10 #872
Conversation
Codecov ReportBase: 94.79% // Head: 94.79% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
=======================================
Coverage 94.79% 94.79%
=======================================
Files 249 249
Lines 25831 25832 +1
=======================================
+ Hits 24487 24488 +1
Misses 1344 1344
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sigh, apparently this functionality already exists in the undocumented |
1de82cc
to
5e7efdd
Compare
Removed old script from test stub, updated CI config, and cleaned up lint. |
Upgrading Pyre requires updating test fixtures with any upstream changes to Pyre's query results for the `simple_class.py` fixture. This adds a new `scripts/` directory to the repo, with a script to regenerate test fixtures. The script regenerates the cache data fixture, and updates the `TypeInferenceProvider` tests to use `assertDictEqual` and helpful error messages for better behavior in future mismatches. This also includes a slight bump to Pyre 0.9.10 to fix install issues on Apple Silicon M1 Macs, and regenerated fixtures using the script above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the old script
Summary
Upgrading Pyre requires updating test fixtures with any upstream changes
to Pyre's query results for the
simple_class.py
fixture.This adds a new
scripts/
directory to the repo, with a script toregenerate test fixtures. The script regenerates the cache data fixture,
and updates the
TypeInferenceProvider
tests to useassertDictEqual
and helpful error messages for better behavior in future mismatches.
This also includes a slight bump to Pyre 0.9.10 to fix install issues on
Apple Silicon M1 Macs, and regenerated fixtures using the script above.
Test Plan
python -m unittest -vk test_type_inference_provider