Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codemod/rename: Avoid duplicating import statements when the module name doesn't change #981

Merged
merged 1 commit into from
Jul 25, 2023
Merged

codemod/rename: Avoid duplicating import statements when the module name doesn't change #981

merged 1 commit into from
Jul 25, 2023

Conversation

zsol
Copy link
Member

@zsol zsol commented Jul 25, 2023

Summary

When renaming within the same module (i.e. logging.warn -> logging.warning), make sure the codemod doesn't insert an extra import logging statement.

Test Plan

Added unit tests

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2023
@zsol zsol force-pushed the codemod/rename-import-same-module branch from 05caa23 to 8082ca4 Compare July 25, 2023 14:32
itamaro
itamaro approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@itamaro itamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@zsol zsol merged commit 9eab2f0 into main Jul 25, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itamaro itamaro itamaro approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zsol @itamaro @facebook-github-bot