Reuse OneDPL implementation of std::nth_element() for partition of 1D array #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
force-pushed
the
fix_crash_in_partition
branch
from
622b1cc
to
bd8be5b
Compare
antonwolfy
requested review from
oleksandr-pavlyk,
vlad-perevezentsev,
npolina4 and
vtavana
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is about to close #1395.
In case of 1d array with C-contiguous data it is possible to use existing OneDPL implementation of
std::nth_element()to make a partition copy of input array with single k-th element index to partition by (while a sequence of k-th element indexes is currently unsupported by dpnp).Additionally,
dpnp.partition()method is extended with complex and boolean types support andpartitionmethod is added to dpnp array.