Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dpnp.square() implementation #1473

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Improve dpnp.square() implementation #1473

merged 1 commit into from
Jul 10, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 10, 2023 •
edited
Loading

The new logic assumes to call square and sin from pybind11 extension of OneMKL VM if possible or fully rely on dpctl.tensor implementation otherwise.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 10, 2023
@npolina4 npolina4 merged commit 457fb55 into master Jul 10, 2023
@npolina4 npolina4 deleted the dpctl_square branch July 10, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolina4 npolina4 npolina4 approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @npolina4