Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade flake8 and black to newer version #1505

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Upgrade flake8 and black to newer version #1505

merged 2 commits into from
Jul 31, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 30, 2023 •
edited
Loading

The PR is aimed to upgrade pre-commit hooks with flake8 and black tools to the latest available version.
The PR also suppresses one new warning E721 reporting by flake8.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 30, 2023
oleksandr-pavlyk
oleksandr-pavlyk approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @antonwolfy

@antonwolfy antonwolfy merged commit c7cdd41 into master Jul 31, 2023
20 checks passed
@antonwolfy antonwolfy deleted the update_flake8_black branch July 31, 2023 14:27
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @oleksandr-pavlyk @vlad-perevezentsev