Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion from raw to multi_ptr should be done with address_space_cast #1538

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Conversion from raw to multi_ptr should be done with address_space_cast #1538

merged 1 commit into from
Aug 27, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 27, 2023 •
edited
Loading

The PR proposes to implement similar fix as dpctl did in gh-1366.
It will help to adopt towards some of the changes in SYCL 2020 for multi_ptr which have introduced breaking changes for SYCL 1.2.1 applications moving to SYCL 2020.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Aug 27, 2023
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antonwolfy antonwolfy merged commit ec46177 into master Aug 27, 2023
21 checks passed
@antonwolfy antonwolfy deleted the create-multi_ptr-per-sycl-2020-standard branch August 27, 2023 17:36
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @oleksandr-pavlyk