Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage dpctl.tensor.copy() implementation #1540

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Leverage dpctl.tensor.copy() implementation #1540

merged 4 commits into from
Aug 28, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 27, 2023 •
edited
Loading

The PR proposes to implement dpnp.copy through dpctl function.
Additionally, the PR adds copy and __copy__ functions to dpnp.ndarray interface.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 27, 2023
@github-actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/1540/index.html

vtavana
vtavana approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @antonwolfy

@antonwolfy antonwolfy merged commit ff71682 into master Aug 28, 2023
21 checks passed
@antonwolfy antonwolfy deleted the dpctl_copy branch August 28, 2023 17:40
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana