Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement dpnp.cbrt, dpnp.exp2, dpnp.copysign, dpnp.rsqrt #1624

Merged
merged 6 commits into from
Nov 24, 2023
Merged

implement dpnp.cbrt, dpnp.exp2, dpnp.copysign, dpnp.rsqrt #1624

merged 6 commits into from
Nov 24, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Nov 14, 2023

The PR changes the implementation of dpnp.cbrt, dpnp.exp2, dpnp.rsqrt, and dpnp.copysign.
dpnp.cbrt and dpnp.exp2 now invoke oneapi::mkl::vm implementation from pybind11 extension of OneMKL VM if possible or use dpctl.tensor implementation if not.
dpnp.rsqrt and dpnp.copysign use dpctl.tensor implementation.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Nov 14, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review November 14, 2023 18:00
npolina4
npolina4 reviewed Nov 14, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_elementwise_common.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_trigonometric.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Nov 22, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_elementwise_common.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_trigonometric.py Show resolved Hide resolved
dpnp/dpnp_iface_trigonometric.py Show resolved Hide resolved
dpnp/dpnp_iface_trigonometric.py Show resolved Hide resolved
tests/test_sycl_queue.py Outdated Show resolved Hide resolved
tests/skipped_tests_gpu_no_fp64.tbl Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_misc.py Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have more comments, LGTM! Thank you @vtavana

@vtavana vtavana merged commit 780d686 into master Nov 24, 2023
37 of 42 checks passed
@vtavana vtavana deleted the cbrt_exp2_rsqrt_copysign branch November 24, 2023 02:45
@antonwolfy antonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolina4 npolina4 npolina4 left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @npolina4 @antonwolfy