Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement dpnp.tensordot #1699

Merged
merged 10 commits into from
Feb 9, 2024
Merged

implement dpnp.tensordot #1699

merged 10 commits into from
Feb 9, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Feb 8, 2024

In this PR, dpnp.tensordot is implemented using existing functions in dpnp.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review February 8, 2024 02:05
antonwolfy
antonwolfy reviewed Feb 8, 2024
View reviewed changes
dpnp/dpnp_iface_linearalgebra.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_linearalgebra.py Outdated Show resolved Hide resolved
tests/third_party/cupy/linalg_tests/test_product.py Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

antonwolfy

This comment was marked as duplicate.

Sign in to view

@vtavana vtavana merged commit 0457fe1 into master Feb 9, 2024
45 checks passed
@vtavana vtavana deleted the dpnp_tensordot branch February 9, 2024 19:48
github-actions bot added a commit that referenced this pull request Feb 9, 2024
@github-actions
implement dpnp.tensordot (#1699)
bf533a9 
* implement dpnp.tensordot

* update doc string

* address comments

* fix doc string

* update scaling factor

* add TODO comment

---------

Co-authored-by: Anton <[email protected]> 0457fe1
@antonwolfy antonwolfy mentioned this pull request Feb 10, 2024
Merged
vlad-perevezentsev pushed a commit that referenced this pull request Feb 12, 2024
@vtavana @antonwolfy @vlad-perevezentsev
implement dpnp.tensordot (#1699)
20f90ed 
* implement dpnp.tensordot

* update doc string

* address comments

* fix doc string

* update scaling factor

* add TODO comment

---------

Co-authored-by: Anton <[email protected]>
antonwolfy added a commit that referenced this pull request Feb 15, 2024
@antonwolfy
Added #1699, #1690 and #1695
f47d935
antonwolfy added a commit that referenced this pull request Feb 15, 2024
@antonwolfy
Preparation for 0.14.0rc1 tag (#1711)
b95b89c 
* Added #1699, #1690 and #1695

* Stepped dpctl version in all dependencies
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Feb 15, 2024
@github-actions
Preparation for 0.14.0rc1 tag (IntelPython#1711)
ced5ae9 
* Added IntelPython#1699, IntelPython#1690 and IntelPython#1695

* Stepped dpctl version in all dependencies b95b89c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy