Update dpnp.linalg.eig/eigvals
#1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antonwolfy also I would also remove the backend implementation of |
We definitely need to plan a clean up, but I would prefer to do that by a separate PR (like to remove all unused linalg functions from backend at once and so on). But needs to be careful to avoid an unexpected impact on numba-dpex. |
|
View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html |
antonwolfy
reviewed
Apr 9, 2024
antonwolfy
approved these changes
Apr 10, 2024
github-actions bot
added a commit
that referenced
this pull request
Apr 11, 2024
* Remove old impl of dpnp_eig and dpnp_eigvals * Update dpnp.linalg.eig func * Update dpnp.linalg.eigvals func * Update test_sycl_queue with eig and eigvals * Update test_usm_type.py with eig and eigvals * Update TestEigenvalue in test_linalg.py * Remove dpnp_algo_linalg.pyx * Update docstrings for solve and matrix_power --------- Co-authored-by: Anton <[email protected]> ceff0c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to update
dpnp.linalg.eig()anddpnp.linalg.eigvals()functions usingnumpycall.Using
numpy.linalg.eig/eigvalsis a temporary solution until MKL implementsoneapi::mkl::lapack::geevfor USM interface.This PR also removes
dpnp_algo_linalg.pyxfile because it no longer contains Cython functions