-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dpnp.linalg.lstsq()
implementation
#1792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html |
antonwolfy
reviewed
Apr 23, 2024
vtavana
reviewed
Apr 23, 2024
antonwolfy
reviewed
Apr 25, 2024
antonwolfy
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vlad-perevezentsev
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Apr 29, 2024
* Add dpnp.linalg.lstsq impl via svd call * Add cupy tests * Add copy of s to compute follows data * Add tests in test_sycl_queue and test_usm_type * Add related_arrays param to dpnp_svd/svd_batch to follow compute follows data * Move above and add docstings for _nrm2_last_axis * Add dpnp tests * Fix codespell check * Get uv_type given related_arrays in dpnp_svd * Check rcond type * Use empty_like in dpnp_svd * rcond as int, float or None * Unlock fix_random() for TestRandint2 --------- Co-authored-by: Anton <[email protected]> f6f660c
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new dpnp.linalg.lstsq) function to calculate the least-squares solution using
dpnp.linalg.svd()
.Also it adds a new helper function
check_2d
to check if the input arrays are two-dimensional.