Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage dpnp.cumprod through dpctl.tensor implementation #1811

Merged
merged 2 commits into from
May 9, 2024
Merged

Leverage dpnp.cumprod through dpctl.tensor implementation #1811

merged 2 commits into from
May 9, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 8, 2024 •
edited
Loading

The PR is about to implement dpnp.cumprod through leveraging on dpctl implementation.

Note dpnp_cumprod is left in the backend code, because it is used by dpnp_nancumprod function also.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this May 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit a079815 into master May 9, 2024
55 of 56 checks passed
@antonwolfy antonwolfy deleted the implement-cumprod branch May 9, 2024 12:42
github-actions bot added a commit that referenced this pull request May 9, 2024
@github-actions
Implement dpnp.cumprod through dpctl.tensor (#1811)
4928630 
Co-authored-by: vtavana <[email protected]> a079815
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request May 13, 2024
@github-actions
Implement dpnp.cumprod through dpctl.tensor (IntelPython#1811)
e50830f 
Co-authored-by: vtavana <[email protected]> a079815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana