Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up legacy linalg implementation from the backend #1887

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Jun 16, 2024

Cleaned up legacy linalg implementation from the backend for speed up build and improve code coverage.

Changes was tested with numda-dpex component.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Jun 16, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change allows significantly improve code coverage. Thank you @npolina4
Btw, it would be great to describe the change with more details in the PR description, stating the motivation and secured avoided impact on dependent component.

@ZzEeKkAa
Copy link
Contributor

I've tested dpex with opencl:cpu and opencl:gpu on iGPU 12th gen - no breaking changes where spotted

@antonwolfy antonwolfy merged commit edcaaa5 into master Jun 19, 2024
46 of 56 checks passed
@antonwolfy antonwolfy deleted the cleanup_linalg branch June 19, 2024 10:25
github-actions bot added a commit that referenced this pull request Jun 19, 2024
* Clean up legacy linalg implementation from the backend

* fix pre-commit edcaaa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants