Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dpnp.isneginf and dpnp.isposinf #1888

Merged
merged 17 commits into from
Jun 26, 2024
Merged

Implement dpnp.isneginf and dpnp.isposinf #1888

merged 17 commits into from
Jun 26, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests adding 2 logical elementt-wise functions dpnp.isposinf() and dpnp.isneginf() by reusing dpnp.inf() and dpnp.signbit() and new tests to cover them

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jun 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Jun 17, 2024
View reviewed changes
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
tests/test_logic.py Show resolved Hide resolved
tests/test_logic.py Outdated Show resolved Hide resolved
tests/test_logic.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Jun 18, 2024
View reviewed changes
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
tests/test_usm_type.py Show resolved Hide resolved
tests/test_sycl_queue.py Outdated Show resolved Hide resolved
tests/test_logic.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev

@antonwolfy antonwolfy self-requested a review June 26, 2024 19:30
@antonwolfy antonwolfy merged commit 0b7c230 into master Jun 26, 2024
54 of 63 checks passed
@antonwolfy antonwolfy deleted the impl_isposinf_isneginf branch June 26, 2024 22:49
github-actions bot added a commit that referenced this pull request Jun 26, 2024
@github-actions
Implement dpnp.isneginf and dpnp.isposinf (#1888)
2cbf609 
* Implement dpnp.isneginf()

* Add tests for dpnp.isneginf()

* Implement dpnp.isposinf()

* Add tests for dpnp.isposinf()

* Add new functions to gen docs

* Add additional checks

* Add test_infinity_sign_errors

* Add sycl_queue/usm tests for logic functions

* Update tests

* Remove out dtype check

* Add TODO with support different out dtype

* Update test_logic_op_2in

---------

Co-authored-by: Anton <[email protected]> 0b7c230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy