Check type of input in dpnp.repeat to raise a proper validation exception if any
#1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
approved these changes
Jun 27, 2024
Co-authored-by: vtavana <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Jun 28, 2024
…eption if any (#1894) * Check type of input to raise a proper validation exception if any * Update dpnp/dpnp_iface_manipulation.py Co-authored-by: vtavana <[email protected]> --------- Co-authored-by: vtavana <[email protected]> 437f046
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That PR proposes to add an explicit type check of input array to
dpnp.repeat.Before the change there was the exception raised about missing
ndimattribute for scalar input.The issue come from the comment.
Also the docstring description was updated with more details about supported input arguments. And more tests scenario were added to cover missing use cases.