Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple einsum utils function to separate file #1920

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Decouple einsum utils function to separate file #1920

merged 4 commits into from
Jul 13, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 12, 2024 •
edited
Loading

The PR proposes to move all utils functions used for implementing dpnp.einsum to dedicated utils file, because it is not used by any other function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 12, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review July 12, 2024 12:40
vtavana
vtavana approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

Base automatically changed from adopt-blas-to-async-dpctl-execution to master July 12, 2024 17:39
@antonwolfy antonwolfy merged commit 58598a1 into master Jul 13, 2024
41 of 45 checks passed
@antonwolfy antonwolfy deleted the add-einsum-utils branch July 13, 2024 10:48
github-actions bot added a commit that referenced this pull request Jul 13, 2024
@github-actions
Decouple einsum utils function to separate file (#1920)
46a732a 
* Update LinAlg functions from BLAS routine

* Decouple einsum utils function to separate file

---------

Co-authored-by: vtavana <[email protected]> 58598a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana