Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable third party tests for dpnp.size #2031

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Enable third party tests for dpnp.size #2031

merged 2 commits into from
Sep 13, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Sep 13, 2024 •
edited
Loading

The PR extends test coverage of dpnp.size implemented in #2014 by enabling third party tests for the function.

The affected tests are unmuted in test_ndarray.py scope and the new test_core.py with more third party tests of core functionality.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Sep 13, 2024
@antonwolfy antonwolfy force-pushed the enable-third-party-tests-for-size branch from c73e593 to 03b7b77 Compare September 13, 2024 13:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit aaf8e4e into master Sep 13, 2024
37 of 46 checks passed
@antonwolfy antonwolfy deleted the enable-third-party-tests-for-size branch September 13, 2024 14:28
github-actions bot added a commit that referenced this pull request Sep 13, 2024
@github-actions
Enable third party tests for dpnp.size (#2031)
a4888b5 
* Enable third party tests for dpnp.size

* Applied pre-commit hooks aaf8e4e
antonwolfy added a commit that referenced this pull request Sep 13, 2024
@antonwolfy
Enable third party tests for dpnp.size (#2031)
d0e9358 
* Enable third party tests for dpnp.size

* Applied pre-commit hooks
antonwolfy added a commit that referenced this pull request Sep 14, 2024
@antonwolfy
Enable third party tests for dpnp.size (#2031)
d106341 
* Enable third party tests for dpnp.size

* Applied pre-commit hooks
@antonwolfy antonwolfy mentioned this pull request Sep 14, 2024
Merged
6 tasks
github-actions bot added a commit that referenced this pull request Sep 14, 2024
@github-actions
Backport gh-2031 d072bd7
8d8a5dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana