Remove TODO from the code as no plan to support negative values in shape setter #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
approved these changes
Sep 13, 2024
antonwolfy
deleted the
remove-todo-for-shape-setter-with-negative-values
branch
antonwolfy
added a commit
that referenced
this pull request
Sep 14, 2024
This was referenced Sep 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to clean the code and to remove the TODO which is no plan to be implemented.
The
shape.setterdocumentation in bothdpnp.ndarrayandusm_ndarrayclearly states that only non-negative new shape value is supported. And it is suggested to usedpnp.reshapeinstead (numpy recommends the same).