Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation of dpnp.require #2036

Merged
merged 11 commits into from
Sep 16, 2024
Merged

implementation of dpnp.require #2036

merged 11 commits into from
Sep 16, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Sep 13, 2024

In this PR, dpnp.require is implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Sep 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review September 14, 2024 01:07
antonwolfy
antonwolfy reviewed Sep 14, 2024
View reviewed changes
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
tests/third_party/cupy/manipulation_tests/test_kind.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
tests/test_manipulation.py Show resolved Hide resolved
tests/test_manipulation.py Show resolved Hide resolved
tests/test_manipulation.py Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana
No more comments from me

@vtavana vtavana merged commit 8cab1af into master Sep 16, 2024
40 of 46 checks passed
@vtavana vtavana deleted the impl_require branch September 16, 2024 20:16
vtavana added a commit that referenced this pull request Sep 16, 2024
@vtavana
implementation of dpnp.require (#2036)
428f51c 
* add dpnp.require

* improve coverage

* address comments

* fix pre-commit

* Input array should be dpnp.ndarray or usm_ndarray

* update CHANGELOG.md
@vtavana vtavana mentioned this pull request Sep 16, 2024
Merged
6 tasks
github-actions bot added a commit that referenced this pull request Sep 16, 2024
@github-actions
implementation of dpnp.require (#2036)
163c2fa 
* add dpnp.require

* improve coverage

* address comments

* fix pre-commit

* Input array should be dpnp.ndarray or usm_ndarray

* update CHANGELOG.md 8cab1af
github-actions bot added a commit that referenced this pull request Sep 16, 2024
@github-actions
Backport gh-2036 211b489
cbd1f4f
antonwolfy pushed a commit that referenced this pull request Sep 17, 2024
@vtavana
implementation of dpnp.require (#2036) (#2054)
4bab635 
* add dpnp.require

* improve coverage

* address comments

* fix pre-commit

* Input array should be dpnp.ndarray or usm_ndarray

* update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy