Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve implementation of dpnp.kron to avoid unnecessary copy for non-contiguous arrays #2059

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Improve implementation of dpnp.kron to avoid unnecessary copy for non-contiguous arrays #2059

merged 4 commits into from
Sep 19, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Sep 17, 2024 •
edited
Loading

In this PR, implementation of dpnp.kron is updated to get rid of unnecessary copy for non-contiguous arrays. There is no need to make input arrays contiguous before performing the calculations. In addition, the final result would be c_contiguous regardless of the status in the middle steps.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana changed the title Improve implementation of dpnp.kron to avoid unnecessary copy Improve implementation of dpnp.kron to avoid unnecessary copy for non-contiguous arrays Sep 17, 2024
@vtavana vtavana marked this pull request as ready for review September 17, 2024 19:37
antonwolfy
antonwolfy approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Thank you @vtavana

tests/test_product.py Show resolved Hide resolved
@vtavana vtavana merged commit 40e4052 into master Sep 19, 2024
39 of 46 checks passed
@vtavana vtavana deleted the update_kron branch September 19, 2024 03:21
vtavana added a commit that referenced this pull request Sep 19, 2024
@vtavana
Improve implementation of dpnp.kron to avoid unnecessary copy for n…
3c45e13 
…on-contiguous arrays (#2059)

* remove continuity check in dpnp.kron

* add additional assert check

* update CHANGELOG.md
@vtavana vtavana mentioned this pull request Sep 19, 2024
Merged
6 tasks
github-actions bot added a commit that referenced this pull request Sep 19, 2024
@github-actions
Improve implementation of dpnp.kron to avoid unnecessary copy for n…
0a4d2c1 
…on-contiguous arrays (#2059)

* remove continuity check in dpnp.kron

* add additional assert check

* update CHANGELOG.md 40e4052
github-actions bot added a commit that referenced this pull request Sep 19, 2024
@github-actions
Backport gh-2059 3ad45f3
e4bc61c
antonwolfy pushed a commit that referenced this pull request Sep 19, 2024
@vtavana
Improve implementation of dpnp.kron to avoid unnecessary copy for n…
7add8ff 
…on-contiguous arrays (#2059) (#2064)

* remove continuity check in dpnp.kron

* add additional assert check

* update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy