Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/njit offload #1041

Merged
merged 7 commits into from
May 15, 2023
Merged

Remove/njit offload #1041

merged 7 commits into from
May 15, 2023

Conversation

diptorupd
Copy link
Collaborator

@diptorupd diptorupd commented May 15, 2023

  • Have you provided a meaningful PR description?
    The PR removes all functionality that was present in numba-dpex to support NumPy offload using parfor nodes. All unit tests are also removed. Offloading NumPy is no longer supported as the equivalent feature has been added using dpnp and the new dpjit decorator.

The following deprecated/broken functionality has been removed:

  1. dpnp overloads using stubs: These overloads were primarily meant to replace equivalent NumPy overloads inside a njit function. These overloads have not been updated to latest dpnp. Moreover, some of these overloads are for functions where dpnp falls back to NumPy. Overloads for dpnp for modules such as linalg and random will be added back post a redesign.
  2. Rename_numpy_functions_pass : Related to the removed dpnp stub overloads. Going forward as dpnp is now directly supported inside dpjit, the rename passes will not be required.
  3. Offload compiler: NumPy offload is no longer supported and the pipeline is no longer needed.
  4. offload_dispatcher: Same reason as offload compiler
  5. retarget.py: Related to the support for dpctl.device_context. As device_context is no longer used and all offload is determined via compute-follows-data programming model the module is no longer required.
  6. dpnp offload unit tests: No longer needed
  7. rename_numpy_functions pass unit test: No longer needed.
  8. parfor fallback, etc. unit tests: No longer supported.
  9. kernel_tests/test_compute_follows_data: Test case is incorrect and a redesigned test will be added along with the fix for Queue inference for numba_dpex kernel args returns incorrect values #1021
  10. dpnp_fptr_interface.pyx: Not supported in current form. Equivalent functionality will be brought back post-redesign.
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd mentioned this pull request May 15, 2023
5 tasks
Copy link
Contributor

@mingjie-intel mingjie-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the dead code, looks good to me.

Copy link
Contributor

@mingjie-intel mingjie-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the dead code, looks good to me.

@diptorupd diptorupd merged commit 5c18691 into main May 15, 2023
@diptorupd diptorupd deleted the remove/njit_offload branch May 15, 2023 15:06
github-actions bot added a commit that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants