-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove/njit offload #1041
Merged
Merged
Remove/njit offload #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingjie-intel
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the dead code, looks good to me.
mingjie-intel
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the dead code, looks good to me.
github-actions bot
added a commit
that referenced
this pull request
May 15, 2023
Remove/njit offload 5c18691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR removes all functionality that was present in numba-dpex to support NumPy offload using parfor nodes. All unit tests are also removed. Offloading NumPy is no longer supported as the equivalent feature has been added using dpnp and the new
dpjit
decorator.The following deprecated/broken functionality has been removed:
njit
function. These overloads have not been updated to latest dpnp. Moreover, some of these overloads are for functions where dpnp falls back to NumPy. Overloads for dpnp for modules such aslinalg
andrandom
will be added back post a redesign.dpjit
, the rename passes will not be required.dpctl.device_context
. Asdevice_context
is no longer used and all offload is determined via compute-follows-data programming model the module is no longer required.