Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tests on single point precision GPUs #1143

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

ZzEeKkAa
Copy link
Collaborator

@ZzEeKkAa ZzEeKkAa commented Sep 25, 2023

Most of the integrated GPUs does not support doble precision and numba by default uses double precision floats. That makes our tests fail on those GPUs. This changes targeted to add support for tests on single precision GPUs by:

  • tests that where using default allocation or only float64/complex128 uses were patched to use float32/complex64 implementations;
  • tests that accept dtype parameters where patched to run only on supported types
  • few issues where found with lowering or silent crashes. Those tests were patched to bypass these cases.

Discovered issues:

  • arctan2 does not work for float32 if device does not support float64 (silent crash)
  • parfor_divide and parfor_exponent does not work on int32 and int64 if device does not support float64 (lowering error)

Issue checks:

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Sep 25, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the feature/support_tests_on_single_point_precision_gpu branch 4 times, most recently from ae1196e to ef901b3 Compare September 27, 2023 14:30
@ZzEeKkAa ZzEeKkAa force-pushed the feature/support_tests_on_single_point_precision_gpu branch from ef901b3 to 0802633 Compare September 27, 2023 14:54
@ZzEeKkAa ZzEeKkAa changed the title WIP: Support tests on single point precision GPUs Support tests on single point precision GPUs Sep 27, 2023
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review September 27, 2023 14:57
Copy link
Collaborator

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Great changes. Please merge after CI is green

@diptorupd diptorupd merged commit b85d379 into main Sep 27, 2023
22 checks passed
@diptorupd diptorupd deleted the feature/support_tests_on_single_point_precision_gpu branch September 27, 2023 15:54
github-actions bot added a commit that referenced this pull request Sep 27, 2023
…ngle_point_precision_gpu

Support tests on single point precision GPUs b85d379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants