Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wheels upload to anaconda #1160

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Add wheels upload to anaconda #1160

merged 1 commit into from
Oct 6, 2023

Conversation

ZzEeKkAa
Copy link
Collaborator

@ZzEeKkAa ZzEeKkAa commented Oct 6, 2023

Just add wheel upload to anaconda dppy/label/dev channel.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Oct 6, 2023
@diptorupd
Copy link
Collaborator

@oleksandr-pavlyk can you please review before we merge?

@ZzEeKkAa ZzEeKkAa marked this pull request as draft October 6, 2023 05:00
@ZzEeKkAa
Copy link
Collaborator Author

ZzEeKkAa commented Oct 6, 2023

Sorry, just found small bug in PR and uploaded fix. Please check wheel size in conda pacakge build step on upload wheel stage before merging/approving.

@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review October 6, 2023 05:08
@ZzEeKkAa
Copy link
Collaborator Author

ZzEeKkAa commented Oct 6, 2023

Yeah, it is ready to go

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

@diptorupd diptorupd merged commit 74d1ed0 into main Oct 6, 2023
31 of 32 checks passed
@diptorupd diptorupd deleted the feature/add_wheels branch October 6, 2023 14:13
github-actions bot added a commit that referenced this pull request Oct 6, 2023
@github-actions
Merge pull request #1160 from IntelPython/feature/add_wheels
a9c6a44 
Add wheels upload to anaconda 74d1ed0
@ZzEeKkAa ZzEeKkAa mentioned this pull request Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZzEeKkAa @diptorupd @oleksandr-pavlyk