Adds all fetch_* SPIR-V overload to experimental #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
force-pushed
the
experimental/more_fetch_phi_fns
branch
from
ba7f25c
to
8be602a
Compare
adarshyoga
force-pushed
the
experimental/more_fetch_phi_fns
branch
from
8be602a
to
7042c6f
Compare
adarshyoga
force-pushed
the
experimental/more_fetch_phi_fns
branch
from
0ee15fc
to
340d3fe
Compare
diptorupd
commented
Jan 8, 2024
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_atomic_ref_overloads.py
Show resolved
Hide resolved
adarshyoga
force-pushed
the
experimental/more_fetch_phi_fns
branch
2 times, most recently
from
5b7b5e8
to
4f309af
Compare
diptorupd
force-pushed
the
experimental/more_fetch_phi_fns
branch
from
4f309af
to
c46dbb0
Compare
diptorupd
commented
Jan 10, 2024
numba_dpex/tests/experimental/kernel_iface/spv_overloads/test_atomic_fetch_phi.py
Show resolved
Hide resolved
diptorupd
commented
Jan 10, 2024
numba_dpex/tests/experimental/kernel_iface/spv_overloads/test_atomic_fetch_phi.py
Outdated
Show resolved
Hide resolved
|
@adarshyoga overall looks great. I will like you to reduce the code duplication in the unit tests and this should be good to go. |
adarshyoga
force-pushed
the
experimental/more_fetch_phi_fns
branch
from
c46dbb0
to
3edf70a
Compare
github-actions bot
added a commit
that referenced
this pull request
Jan 10, 2024
…_fns Adds all fetch_* SPIR-V overload to experimental 315b6e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you provided a meaningful PR description?
Adds the remaining overloads for
fetch_*functions to the_atomic_ref_overloadsmodule. These include - fetch_sub, fetch_min, fetch_max, fetch_and, fetch_or, and fetch_xor.This PR also contains positive and negative test cases for testing out each of the atomic functions
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?