Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dpjit specific data model #1274

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

ZzEeKkAa
Copy link
Collaborator

@ZzEeKkAa ZzEeKkAa commented Jan 9, 2024

An attempt to use dpjit specific datamodel.

While there are some blockers, this PR provides better codestyle, like using datamodels from context, instead of requesting them globally.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Jan 9, 2024
@ZzEeKkAa ZzEeKkAa marked this pull request as draft January 9, 2024 22:35
@ZzEeKkAa ZzEeKkAa force-pushed the feature/use_dpjit_specific_data_model branch 3 times, most recently from 5fd0da2 to d513a0f Compare March 29, 2024 21:41
@ZzEeKkAa ZzEeKkAa changed the title WIP: use dpjit specific data model Use dpjit specific data model Mar 29, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/use_dpjit_specific_data_model branch from d513a0f to 9bb4a47 Compare March 29, 2024 21:46
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review March 29, 2024 21:47
@coveralls
Copy link
Collaborator

coveralls commented Mar 29, 2024

Coverage Status

coverage: 84.825% (+0.02%) from 84.81%
when pulling 9bb4a47 on feature/use_dpjit_specific_data_model
into af226f3 on main.

@ZzEeKkAa ZzEeKkAa merged commit f6a79b4 into main Mar 29, 2024
42 of 50 checks passed
@ZzEeKkAa ZzEeKkAa deleted the feature/use_dpjit_specific_data_model branch March 29, 2024 22:26
github-actions bot added a commit that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants