Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Age update implemented for projection #7661

Merged
merged 25 commits into from
Jan 19, 2021
Merged

Age update implemented for projection #7661

merged 25 commits into from
Jan 19, 2021

Conversation

MMirbach
Copy link
Contributor

The age is now updated in the DSM on setup.
When AC is run the age and last AC fields in DSM are updated, the fields that involve the MC are not changed

src/l500/l500-device.cpp Outdated Show resolved Hide resolved
src/l500/l500-private.cpp Outdated Show resolved Hide resolved
src/l500/l500-private.cpp Outdated Show resolved Hide resolved
src/l500/l500-private.cpp Outdated Show resolved Hide resolved
src/l500/l500-private.h Outdated Show resolved Hide resolved
src/l500/l500-private.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@maloel maloel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good

@dorodnic
Copy link
Contributor

Change in types.h == API break
@ev-mp @maloel - lets review

@maloel
Copy link
Collaborator

maloel commented Nov 4, 2020

Change in types.h == API break
@ev-mp @maloel - lets review

@dorodnic
This struct is a direct FW representation, only relevant in AC. The struct size has not changed, and the previous fields are unchanged -- but the reserved bytes (0s before) have gained meaning.

@MMirbach
LRS still writes the struct as "version 1", which could be improved. Maybe write_fw_table can accept a version number, in which case the version would be increased to 2 -- but then read_fw_table needs to be able to return the table version, too, and we'll possibly want to check it.

src/l500/l500-device.cpp Outdated Show resolved Hide resolved
src/l500/l500-device.cpp Outdated Show resolved Hide resolved
src/l500/l500-device.cpp Outdated Show resolved Hide resolved
@maloel maloel merged commit eda59b3 into IntelRealSense:development Jan 19, 2021
@MMirbach MMirbach deleted the projection_fix branch February 24, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants