Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "/p list" default to "/p list mine" #3827

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ConfusedAlex
Copy link

Overview

Fixes #{issue number}

Description

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@ConfusedAlex ConfusedAlex requested a review from a team as a code owner October 5, 2022 18:43
TranslatableCaption.of("commandconfig.subcommand_set_options_header"),
Templates.of("values", Arrays.toString(getArgumentList(player)))
);
onCommand(player, new String[]{"mine"});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels kinda hacky and dirty imo - The logic for the mine-subcmd should be extracted into a (private) method and called by that. The noArgs method has no real use-case anymore.

@NotMyFault NotMyFault added the needs-justification The motivation and desired outcome needs to be clarified. label Oct 6, 2022
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs justification, why the code as-is doesn't suffice, and how the proposal addresses the issue, which is yet to clarify.

@ConfusedAlex
Copy link
Author

proposal addresses the issue

This PR would close and implement #3621.

@github-actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-justification The motivation and desired outcome needs to be clarified. unresolved-merge-conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants