Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 UserId interpreted as string issue #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pythagus
Copy link

@Pythagus Pythagus commented Oct 1, 2024

Dear team,

I installed the package today and directly faced an issue with the MaxmindWebService service...

In Client.php line 83:
GeoIp2\WebService\Client::__construct(): Argument #1 ($accountId) must be of type int, string given, called in /*****/vendor/interaction-design-foundation/laravel-geoip/src/Services/MaxMindWebService.php on line 27 

This is because the $this->config helper will return a string instead of an integer, as expected by the MaxMind Client class.

I only added a (int) before the user ID, so that it is interpreted as an integer 👼

I am kind of surprised that this issue didn't raise before... If I am the only one facing this issue, please forget about this Pull Request.

Regards,

Pythagus 🐛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant