🐛 UserId interpreted as string issue #37
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear team,
I installed the package today and directly faced an issue with the MaxmindWebService service...
This is because the
$this->config
helper will return a string instead of an integer, as expected by the MaxMindClient
class.I only added a
(int)
before the user ID, so that it is interpreted as an integer 👼I am kind of surprised that this issue didn't raise before... If I am the only one facing this issue, please forget about this Pull Request.
Regards,
Pythagus 🐛