upgrading the searchbar to select country through a world-map #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgiakatos
requested changes
Mar 5, 2024
src/components/search/SearchBar.vue
Outdated
| @@ -368,11 +379,19 @@ const placeholder = computed(() => { | |||
| hide-selected | |||
| > | |||
| <template v-slot:append> | |||
| <div v-if="!loading"> | |||
| <QIcon :color="label" name="fas fa-search q-mb-xs" width="0.82em" /> | |||
| <div v-if="props.noAS" @click="showMap"> | |||
There was a problem hiding this comment.
Change props.noAS to !props.noCountry
There was a problem hiding this comment.
Added :noCountry="true" in Searchbar of Header Component and changed props.noAS to !props.noAS
There was a problem hiding this comment.
Please revert your changes in the Header Component. The user must be able to search for a country. Keep your changes limited to the issues mentioned in the review. Thank you.
src/components/maps/WorldMap.vue
Outdated
| @@ -0,0 +1,91 @@ | |||
|
|
|||
src/components/maps/WorldMap.vue
Outdated
| import { ref, onMounted, inject, getCurrentInstance } from 'vue' | ||
| import ReactiveChart from '@/components/charts/ReactiveChart.vue' | ||
| import { CountryQuery } from '@/plugins/IhrApi' | ||
| const {emit} = getCurrentInstance() |
There was a problem hiding this comment.
We do not define emits in that manner. Please adhere to the project's code style guidelines.
src/components/maps/WorldMap.vue
Outdated
| } | ||
| } | ||
|
|
||
| onMounted(fetchData) |
There was a problem hiding this comment.
We do not use mounted function in that manner. Please adhere to the project's code style guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recording.2024-03-02.103915.mp4