Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Resilience + SD.Next Support #160

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

DrCyanide
Copy link

I've added code to check what the associated backend actually requires for it's txt2img and img2img calls, then pass only those parameters into wrap_gradio_gpu_call(). If a parameter is not in the dictionary of known parameters, the code will look at the datatype and provide a "default" value for that parameter, making the extension more likely to get an image back than crash. Also added console warnings when parameters are missing, giving their name and datatype, making it easier for users to maintain future updates.

Due to the way this update grabs parameters, it works with both Automatic1111 and Vlads/SD.Next backends (and will likely work with any forks of those).

This update also makes the extension drastically more forwards and backwards compatible. Updated versions of the extension won't crash on older UIs, and updated UIs won't crash this version of the extension as easily.

I know @Interpause is looking to get out of maintaining this repo. I think this update might be the best way to do that, because it drastically reduces the complexity of maintenance, and helps give end users the information to fix their local copies.

Fixes #158 #155 #152 #151 #144 and probably many others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The extension doesn't work at all (img2img() missing 3 required positional arguments)
2 participants