-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose functions and types from cardano-ledger-alonzo
and cardano-ledger-byron
required by cardano-cli
#647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
carbolymer,
smelc,
kevinhammond,
CarlosLopezDeLara and
disassembler
as code owners
October 1, 2024 17:51
smelc
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
Thanks for the detailed How to trust this PR instructions 💯
Jimbo4350
requested changes
Oct 3, 2024
Jimbo4350
requested changes
Oct 3, 2024
palas
force-pushed
the
remove-transitive-deps-ledger-backport
branch
from
October 4, 2024 17:26
320811f
to
af99006
Compare
Jimbo4350
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
palas
force-pushed
the
remove-transitive-deps-ledger-backport
branch
from
October 4, 2024 18:06
af99006
to
a7470b6
Compare
palas
force-pushed
the
remove-transitive-deps-ledger-backport
branch
from
October 4, 2024 18:08
a7470b6
to
4f9b7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to self: write API changes in changelog before merging
Changelog
Context
As part of the work targeted at addressing issues pointed out in #608, this PR aims to provide
cardano-cli
with everything it needs from ledger (in this PRalonzo
andbyron
parts),How to trust this PR
Make sure it is just a refactoring for
cardano-cli
.Make sure the way new things are exposed is sensible.
Look at it in conjunction with: IntersectMBO/cardano-cli#920
Most commits are linked 1 to 1 with commits in the
cardano-cli
PR.Checklist